close
Skip to content

[asyncio] bpo-29743: ssl socket leak during handshake #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1st1 merged 3 commits into from
Jun 9, 2017
Merged

[asyncio] bpo-29743: ssl socket leak during handshake #480

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
225606c
Closing transport during handshake process leaks socket
fafhrd91 Mar 5, 2017
faa4b5c
Merge branch 'master' into ssl-handshake-cancel
1st1 Mar 12, 2017
47446a2
Merge branch 'master' into ssl-handshake-cancel
Jun 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into ssl-handshake-cancel
  • Loading branch information
@1st1
1st1 authored Mar 12, 2017
commit faa4b5c685057b085f89269b705fd421a2d6d5d9
11 changes: 11 additions & 0 deletions Lib/test/test_asyncio/test_sslproto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,17 @@ def do_handshake(callback):
ssl_proto._app_transport.close()
self.assertTrue(transport.abort.called)

def test_get_extra_info_on_closed_connection(self):
waiter = asyncio.Future(loop=self.loop)
ssl_proto = self.ssl_protocol(waiter)
self.assertIsNone(ssl_proto._get_extra_info('socket'))
default = object()
self.assertIs(ssl_proto._get_extra_info('socket', default), default)
self.connection_made(ssl_proto)
self.assertIsNotNone(ssl_proto._get_extra_info('socket'))
ssl_proto.connection_lost(None)
self.assertIsNone(ssl_proto._get_extra_info('socket'))


if __name__ == '__main__':
unittest.main()
You are viewing a condensed version of this merge commit. You can view the full changes here.