gh-64490: Tweak AC implementation for **kwds - #139133
Open
AA-Turner wants to merge 5 commits into
Open
Conversation
erlend-aasland
requested review from
serhiy-storchaka
and removed request for
erlend-aasland
September 18, 2025 15:48
Contributor
|
Deferring to Serhiy, as this is addressing his review remarks. |
johncarlomartinez570-cmd
approved these changes
Oct 21, 2025
|
This PR is stale because it has been open for 30 days with no activity. |
serhiy-storchaka
approved these changes
Aug 22, 2026
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Resolved conflicts and added more tests to address my comments (including the one from 138344). LGTM now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses @serhiy-storchaka's comments following initial merge (thank you Serhiy for the reviews!).
A