close
Skip to content

refactor: enhance UX for missing build tools prompt #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgrim merged 1 commit into from
Jun 29, 2026
Merged

refactor: enhance UX for missing build tools prompt #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DependencyResolver/DependencyInstaller/PrescanSystemDependencies.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ static function (DependencyStatus $dependencyStatus): bool {
$this->io->write(sprintf('<info>Need to install missing system dependencies:</info> %s', $proposedInstallCommand));

if ($this->io->isInteractive() && ! $autoInstallIfMissing) {
if (! $this->io->askConfirmation('<question>Would you like to install them now?</question>', false)) {
if (! $this->io->askConfirmation('<question>Would you like to install them now? [y/N]</question>', false)) {
$this->io->write('<comment>Ok, but things might not work. Just so you know.</comment>');

return;
Expand Down
2 changes: 1 addition & 1 deletion src/SelfManage/BuildTools/CheckAllBuildTools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public function check(IOInterface $io, PackageManager|null $packageManager, Targ
$io->write('The following command will be run: ' . $proposedInstallCommand, verbosity: IOInterface::VERBOSE);

if ($io->isInteractive() && ! $autoInstallIfMissing) {
if (! $io->askConfirmation('<question>Would you like to install them now?</question>', false)) {
if (! $io->askConfirmation('<question>Would you like to install them now? [y/N]</question>', false)) {
$io->write('<comment>Ok, but things might not work. Just so you know.</comment>');

return;
Expand Down
1 change: 1 addition & 0 deletions test/unit/SelfManage/BuildTools/CheckAllBuildToolsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ public function testCheckInstallsMissingToolWhenPromptedInInteractiveMode(): voi
$outputString = $io->getOutput();
self::assertStringContainsString('Checking if all build tools are installed.', $outputString);
self::assertStringContainsString('The following build tools are missing: bloop', $outputString);
self::assertStringContainsString('Would you like to install them now? [y/N]', $outputString);
self::assertStringContainsString('The following command will be run: echo "fake installing coreutils"', $outputString);
self::assertStringContainsString('Missing build tools have been installed.', $outputString);
}
Expand Down
Loading