fix: tambah fpm_trace_continue() pada backend trace mach - #23391
Open
feri220899 wants to merge 1 commit into
Open
fix: tambah fpm_trace_continue() pada backend trace mach#23391feri220899 wants to merge 1 commit into
feri220899 wants to merge 1 commit into
Conversation
Menambahkan fungsi untuk melanjutkan (SIGCONT) proses yang sebelumnya dihentikan via ptrace di backend macOS, melengkapi fungsi stop yang sudah ada.
NickSdot
reviewed
Aug 20, 2026
NickSdot
left a comment
Contributor
There was a problem hiding this comment.
- maybe you want to add a test to show what this is supposed to do?
- can you please change the PR title to English?
| } | ||
| /* }}} */ | ||
|
|
||
| int fpm_trace_continue(pid_t pid) /* {{{ */ |
Contributor
There was a problem hiding this comment.
You do not call this from anywhere?
LamentXU123
requested changes
Aug 20, 2026
LamentXU123
left a comment
Member
There was a problem hiding this comment.
I don't understand, this function you added seems to not have any call sites, and only adds dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for resuming a process (
SIGCONT) that was previously stopped viaptracein the macOS backend.The macOS backend already provides functionality for stopping a traced process. This change complements that behavior by adding the corresponding resume functionality, allowing a stopped process to continue execution when required.
This makes the process-control behavior more complete and provides a proper counterpart to the existing stop operation on macOS.
Changes
SIGCONT.ptracebackend.