Initial rename of async to multiprocess_pool for python3.7 compatibility - #93
Merged
Merged
Conversation
|
@b4oshany can we get this in? Would go a long ways to keep the project viable in old apps that need to move up to 3.7 without a rewrite. |
Author
|
@chris-erickson Can also assit in moving more asyncio functionality into this library. |
Collaborator
|
Hi @chris-erickson, I'll test it and merge it when I'm finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I had a quick look at the python3.7 compatibility. A full fix would be porting the functionality to python3.7's async await syntax. Multiprocessing has a async functionality, but as far as I can see its not used here.
Renamed the file and its references, should still operate the same.
Python version: Python 3.7.1 (linux)
Did run python setup.py test from a python3.7 virtualenv.
test_conversion (tests.jsonutil_test.JSONTestCase) ... ok
test_total_seconds (tests.jsonutil_test.JSONTestCase) ... ok
test_build_endpoint_url (tests.firebase_test.FirebaseTestCase) ... ok
test_make_delete_request (tests.firebase_test.FirebaseTestCase) ... ok
test_make_get_request (tests.firebase_test.FirebaseTestCase) ... ok
test_make_patch_request (tests.firebase_test.FirebaseTestCase) ... ok
test_make_post_request (tests.firebase_test.FirebaseTestCase) ... ok
test_make_put_request (tests.firebase_test.FirebaseTestCase) ... ok