close
Skip to content

Add bsd and linux sed compatibility check - #35

Merged
Brayden merged 1 commit into
outerbase:mainfrom
JayJamieson:bugfix/fix-install-script-sed-platform-bug
Nov 10, 2024
Merged

Add bsd and linux sed compatibility check#35
Brayden merged 1 commit into
outerbase:mainfrom
JayJamieson:bugfix/fix-install-script-sed-platform-bug

Conversation

@JayJamieson

Copy link
Copy Markdown
Contributor

Purpose

Addresses #32 install.sh bug when installing on Linux platforms.

Couldn't find installs script in source control, adding it along with fix. Specific fix is on lines 44-65.

os=$(uname -s)
PLATFORM_SED="sed -i ''"

# choose correct version of sed utility for platform
case "$os" in
    Linux*)
        # GNU utilities
        PLATFORM_SED="sed -i"
        ;;
    Darwin*)
        # BSD utilities (macOS)
        PLATFORM_SED="sed -i ''"
        ;;
    *BSD*)
        # Other BSD variants (FreeBSD, OpenBSD, etc)
        PLATFORM_SED="sed -i ''"
        ;;
    *)
        echo "Unknown operating system: $os"
        exit 1
        ;;
esac

@Brayden Brayden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for resolving that issue. This is great!

@Brayden
Brayden merged commit af01346 into outerbase:main Nov 10, 2024
@JayJamieson
JayJamieson deleted the bugfix/fix-install-script-sed-platform-bug branch November 10, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants