close
Skip to content

[FSSDK-8823] chore: prepare for release 4.0.0 - #411

Merged
pulak-opti merged 6 commits into
masterfrom
pulak/prepare-release-4.0
Jan 22, 2024
Merged

[FSSDK-8823] chore: prepare for release 4.0.0#411
pulak-opti merged 6 commits into
masterfrom
pulak/prepare-release-4.0

Conversation

@pulak-opti

@pulak-opti pulak-opti commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Summary

  • prepare for release 4.0.0
  • use go-sdk v2

Issues

@pulak-opti
pulak-opti marked this pull request as ready for review January 19, 2024 19:10

@mikechu-optimizely mikechu-optimizely left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Do we need to update the paths in the Makefile?

@jaeopt jaeopt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A suggestion for CHANGELOG.

Comment thread CHANGELOG.md
@pulak-opti

Copy link
Copy Markdown
Contributor Author

LGTM, but Do we need to update the paths in the Makefile?

Yes, good catch, thanks

@pulak-opti
pulak-opti requested a review from jaeopt January 22, 2024 12:19

@mikechu-optimizely mikechu-optimizely left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pulak-opti
pulak-opti merged commit c563262 into master Jan 22, 2024
@pulak-opti
pulak-opti deleted the pulak/prepare-release-4.0 branch January 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants