Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
Accelerator
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
nodejs
/
node
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
36.6k
Star
119k
Code
Issues
635
Pull requests
754
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
repl: refactor to avoid unsafe array iteration
- #36444
#36444
Closed
RaisinTen
wants to merge 20 commits into
nodejs:master
nodejs/node:master
from
RaisinTen:lib/refactor-to-remove-for-of-loop-with-let-in-repl.js
RaisinTen/node:lib/refactor-to-remove-for-of-loop-with-let-in-repl.js
Copy head branch name to clipboard
Conversation
Commits
20
(20)
Checks
Files changed
Closed
repl: refactor to avoid unsafe array iteration
#36444
RaisinTen
wants to merge 20 commits into
nodejs:master
nodejs/node:master
from
RaisinTen:lib/refactor-to-remove-for-of-loop-with-let-in-repl.js
RaisinTen/node:lib/refactor-to-remove-for-of-loop-with-let-in-repl.js
Copy head branch name to clipboard
Commits
Commits on Dec 8, 2020
lib: refactor to remove for-let-of loop in repl.js
RaisinTen
committed
b81f448
View commit details
Copy full SHA for b81f448
Browse repository at this point
Commits on Dec 10, 2020
Apply suggestion from code review
Show description for f5d6c33
RaisinTen
and
aduh95
authored
f5d6c33
View commit details
Copy full SHA for f5d6c33
Browse repository at this point
lib: require ArrayPrototypeForEach in repl.js
RaisinTen
committed
b6b3c5b
View commit details
Copy full SHA for b6b3c5b
Browse repository at this point
lib: fix syntax error repl.js
RaisinTen
committed
0a167a1
View commit details
Copy full SHA for 0a167a1
Browse repository at this point
lib: replace another loop repl.js
RaisinTen
committed
3a9491e
View commit details
Copy full SHA for 3a9491e
Browse repository at this point
lib: fix lint error repl.js
RaisinTen
committed
846ac65
View commit details
Copy full SHA for 846ac65
Browse repository at this point
Commits on Dec 11, 2020
Apply suggestions from code review
Show description for 9367f9b
RaisinTen
and
aduh95
authored
9367f9b
View commit details
Copy full SHA for 9367f9b
Browse repository at this point
lib: replace all for loops with ArrayPrototypeForEach in repl.js
RaisinTen
committed
61cb3b7
View commit details
Copy full SHA for 61cb3b7
Browse repository at this point
lib: fix syntax error repl.js
RaisinTen
committed
10c1759
View commit details
Copy full SHA for 10c1759
Browse repository at this point
lib: fix lint error
RaisinTen
committed
669f93e
View commit details
Copy full SHA for 669f93e
Browse repository at this point
Commits on Dec 16, 2020
lib: replace ArrayPrototypeSort with ArrayPrototypeForEach in repl.js
RaisinTen
committed
dc678b0
View commit details
Copy full SHA for dc678b0
Browse repository at this point
Commits on Dec 18, 2020
test: add unsafe array iteration test to repl
RaisinTen
committed
ddfbfc4
View commit details
Copy full SHA for ddfbfc4
Browse repository at this point
test: add notStrictEqual check instead for repl.js
RaisinTen
committed
77a6be5
View commit details
Copy full SHA for 77a6be5
Browse repository at this point
Update test/parallel/test-repl-unsafe-array-iteration.js
Show description for 6c19991
RaisinTen
and
aduh95
authored
6c19991
View commit details
Copy full SHA for 6c19991
Browse repository at this point
Commits on Dec 19, 2020
test: add test using child_process instead
RaisinTen
committed
ccc860a
View commit details
Copy full SHA for ccc860a
Browse repository at this point
test: remove error code check
RaisinTen
committed
81776d6
View commit details
Copy full SHA for 81776d6
Browse repository at this point
Update test/parallel/test-repl-unsafe-array-iteration.js
Show description for a45f1ed
RaisinTen
and
aduh95
authored
a45f1ed
View commit details
Copy full SHA for a45f1ed
Browse repository at this point
Update test/parallel/test-repl-unsafe-array-iteration.js
Show description for c61b0b9
RaisinTen
and
aduh95
authored
c61b0b9
View commit details
Copy full SHA for c61b0b9
Browse repository at this point
Commits on Dec 20, 2020
Update test/parallel/test-repl-unsafe-array-iteration.js
Show description for 71350bd
RaisinTen
and
aduh95
authored
71350bd
View commit details
Copy full SHA for 71350bd
Browse repository at this point
Commits on Dec 21, 2020
Update test/parallel/test-repl-unsafe-array-iteration.js
Show description for 1ec7036
RaisinTen
and
aduh95
authored
1ec7036
View commit details
Copy full SHA for 1ec7036
Browse repository at this point
You can’t perform that action at this time.