close
Skip to content

fix(cronjob): include container (service) cronjobs in list - #1981

Merged
martin-helmich merged 1 commit into
masterfrom
fix/1980-list-container-cronjobs
Jul 3, 2026
Merged

fix(cronjob): include container (service) cronjobs in list#1981
martin-helmich merged 1 commit into
masterfrom
fix/1980-list-container-cronjobs

Conversation

@martin-helmich

Copy link
Copy Markdown
Member

Summary

mw cronjob list did not return cronjobs belonging to containers, because the cronjob list API excludes service cronjobs by default.

This passes includeServiceCronjobs: true in the query parameters so container/service cronjobs are listed as well.

Fixes #1980

🤖 Generated with Claude Code

The `mw cronjob list` command did not return cronjobs belonging to
containers, because the API defaults to excluding service cronjobs.
Pass `includeServiceCronjobs: true` so they are listed as well.

Fixes #1980

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@martin-helmich
martin-helmich merged commit 5c03091 into master Jul 3, 2026
11 checks passed
@martin-helmich
martin-helmich deleted the fix/1980-list-container-cronjobs branch July 3, 2026 08:23
martin-helmich added a commit that referenced this pull request Jul 3, 2026
## Summary

Follow-up to #1981 (container cron job support in `cronjob list`).

A cron job may target an **app installation** OR a **container** (a
service running in a stack). `mw cronjob get` previously always resolved
the cron job's app installation (`useAppInstallation(cronjob.appId)`),
which fails or renders misleading output for container cron jobs.

`CronJobDetails` now branches on the cron job's `target`:

- **Container (service) targets** — show the **Stack** and **Container**
instead of an App, and render the container **command** as the execution
target.
- **App targets** — rendered as before (via `appInstallationId`, falling
back to the deprecated `appId`).

Because the app-installation lookup now lives in a dedicated
subcomponent, it is only performed for app cron jobs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
mittwald-machine added a commit that referenced this pull request Jul 3, 2026
## [1.20.1](v1.20.0...v1.20.1) (2026-07-03)

### Bug Fixes

* **cronjob:** include container (service) cronjobs in list ([#1981](#1981)) ([5c03091](5c03091)), closes [#1980](#1980)
* **cronjob:** render container cron jobs in "cronjob get" ([#1982](#1982)) ([97f5475](97f5475)), closes [#1981](#1981)
* **release:** do not specify model explicitly when announcing release ([b21740f](b21740f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mw cronjob list does not list container cronjobs

1 participant