sessions: keep chat input above mobile keyboard - #332148
Open
Aaron Munger (amunger) wants to merge 1 commit into
Open
sessions: keep chat input above mobile keyboard#332148Aaron Munger (amunger) wants to merge 1 commit into
Aaron Munger (amunger) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Keeps the phone Agents chat composer visible above mobile virtual keyboards.
Changes:
- Clamp phone layouts to the visual viewport height.
- Relayout Android sessions when the visual viewport resizes.
- Add focused viewport clamping and fallback tests.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/browser/workbench.ts |
Integrates visual viewport sizing and resize handling. |
src/vs/sessions/browser/parts/mobile/mobileVisualViewport.ts |
Adds the viewport dimension helper. |
src/vs/sessions/test/browser/mobileVisualViewport.test.ts |
Tests height clamping and fallbacks. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
Aaron Munger (amunger)
marked this pull request as ready for review
August 23, 2026 15:48
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Size phone layouts to the visual viewport and relayout Android sessions when the virtual keyboard changes the visible area. Reuse the existing iOS viewport resize path and cover the dimension fallback with a focused test.\n\nFixes #332146\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Aaron Munger (amunger)
force-pushed
the
agents/start-local-web-server-for-ui-testing
branch
from
August 23, 2026 17:28
1e81fc9 to
e3704f9
Compare
Martin Aeschlimann (aeschli)
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visualViewport.resizewhile reusing the existing iOS resize pathFixes #332146
Validation
npm run transpile-clientnpm run typecheck-clientmobileVisualViewport.test.ts,mobileSessionsPart.test.ts739.9to446.7with a515pxvisible viewport564to424with a520pxvisible viewportEnvironment notes
npm run compilereached an unrelated existingextensions/ipynbfailure for missingmarkdown-itdeclarations in this fresh worktreenpm run hygienehit an unrelated Windows path resolution failure (Q:\Q:\...\remote\package.json)