parallelize Descriptions setup, fix response leak, use typed stream keys - #3044
Merged
Conversation
- Dispose HttpResponseMessage in LoadFromUrlAsync (was leaking on every download) - Run the assembly reads and GHES downloads concurrently in GlobalSetup via Task.WhenAll instead of sequential awaits; aggregate into _streams afterward to avoid concurrent Dictionary writes - Replace string-keyed _streams (mixed file names / URLs) with a private DescriptionSource enum for compile-time-checked, pre-sized lookups - Drop the redundant async/await wrapper on each [Benchmark] method so the MemoryDiagnoser numbers reflect ParseDocumentAsync, not an extra state machine - Derive the four pinned GHES description URLs from one commit SHA constant instead of duplicating it across four literals - Add an HttpClient timeout; modernize Assembly access; align field naming
Vincent Biret (baywet)
approved these changes
Aug 20, 2026
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aggregate into _streams afterward to avoid concurrent Dictionary writes
compile-time-checked, pre-sized lookups
measures ParseDocumentAsync, not an extra state machine
Descriptions