Add combobox role to button and input[type="button"] - #22459
Merged
Conversation
hudochenkov
requested review from
a team and
estelle
and removed request for
a team
November 21, 2022 17:33
hudochenkov
force-pushed
the
button-combobox
branch
from
November 21, 2022 17:36
b60567d to
e6d361e
Compare
Contributor
|
Preview URLs Flaws (4)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
|
hudochenkov
force-pushed
the
button-combobox
branch
from
November 22, 2022 12:36
e6d361e to
2fc7f3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
comboboxrole tobuttonelement andinput[type="button"].Motivation
comboboxrole forbuttonelement andinput[type="button"]was added to ARIA in HTML on January 15, 2022. Aligning MDN documentation to spec.Additional details
Related docs for
buttonand forinput[type="button"].