Add security-sensitive change review checklist - #42
Open
mattpodwysocki wants to merge 1 commit into
Open
Conversation
Prompted by a Slack discussion about relying on reviewer intuition to catch high-blast-radius issues (auth, credentials, session state). mcp-devkit-server PR #57 is the worked example: a cross-session credential-hijack bug and several resource-exhaustion gaps got past the original implementation and a full round of human review, caught only by later, independently-run adversarial passes. Adds a visible PR template section plus CONTRIBUTING guidance covering: running /security-review (noting its explicit DoS/resource-exhaustion exclusions), writing down adversarial scenarios, adding a regression test proving the bug was real, and 2+ reviewer approval as a backstop. This is a prompt, not a CI gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mapbox/mcp-devkit-server#57is the worked example we used: a cross-session credential-hijack bug and several resource-exhaustion gaps got past the original implementation and a full round of human review, and were only caught by later, independently-run adversarial passes.CONTRIBUTING.md.Test plan