feat(mount)!: introduce Mount Middleware and obsolete app.mount - #5221
Draft
yusukebe wants to merge 1 commit into
Draft
feat(mount)!: introduce Mount Middleware and obsolete app.mount#5221yusukebe wants to merge 1 commit into
app.mount#5221yusukebe wants to merge 1 commit into
Conversation
yusukebe
marked this pull request as draft
August 12, 2026 12:27
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
Reported by octocov |
HTTP Performance Benchmark
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5221 +/- ##
==========================================
+ Coverage 79.77% 79.92% +0.15%
==========================================
Files 155 156 +1
Lines 10930 10906 -24
Branches 2290 2290
==========================================
- Hits 8719 8717 -2
+ Misses 2211 2189 -22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Hey @usualoma ! What do you think of moving the mount feature from |
Member
|
@yusukebe I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that
app.mount()doesn't need to be placed inhono-base.ts. The codebase ofapp.mount()is a little bit fat compared to other methods inhono-base.ts, though the lines are very few in the real world. Anyway, the unnecessary should be removed fromhono-base.ts.So, we can make it a middleware called Mount Middleware. The usage is below:
I think the API syntax is very Hono-like and love it.
As a result, the bundle size will be
501Bsmaller (vs current main):This PR will obsolete
app.mount()completely, so this is a breaking change. Should be introduced in the next major release v5.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code