close
Skip to content

remove redundant rules from .editorconfig - #2157

Merged
roblarsen merged 1 commit into
masterfrom
editorconfig-rules
Oct 14, 2019
Merged

remove redundant rules from .editorconfig#2157
roblarsen merged 1 commit into
masterfrom
editorconfig-rules

Conversation

@coliff

@coliff coliff commented Sep 9, 2019

Copy link
Copy Markdown
Member

This removes the unnecessary:

[{.travis.yml,package.json}]
# The indent size used in the `package.json` file cannot be changed
# https://github.com/npm/npm/pull/3180#issuecomment-16336516
indent_size = 2
indent_style = space

The preceding rules state indent size of 2 and spaces anyway. (plus that linked GitHub issue regarding package.json has been fixed as of npm 5)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coliff
coliff requested a review from roblarsen September 9, 2019 04:09
@coliff coliff mentioned this pull request Sep 9, 2019
6 tasks
@roblarsen
roblarsen merged commit 60beb6f into master Oct 14, 2019
@coliff
coliff deleted the editorconfig-rules branch October 15, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants