close
Skip to content

feat(gax): allow non-JSON HttpContent and absolute request URLs in HttpRequestRunnable - #14134

Draft
whowes wants to merge 1 commit into
mainfrom
whowes/http-content-support
Draft

feat(gax): allow non-JSON HttpContent and absolute request URLs in HttpRequestRunnable#14134
whowes wants to merge 1 commit into
mainfrom
whowes/http-content-support

Conversation

@whowes

@whowes whowes commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

GAX HTTP infrastructure currently assumes that

  • request content is always JSON
  • request URLs are always based on the client context associated with the service stub

This PR relaxes those assumptions to allow non-JSON content and arbitrary URLs, which will be needed for resumable upload support.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for non-JSON HTTP content and absolute URLs in HttpRequestRunnable. It adds a default getHttpContent method to HttpRequestFormatter to retrieve the request body as HttpContent, allowing custom content types like binary payloads. Additionally, HttpRequestRunnable is updated to handle absolute paths directly, bypassing endpoint normalization when the path starts with http:// or https://. Corresponding unit tests have been added to verify these changes. There are no review comments, and I have no additional feedback to provide.

@whowes whowes changed the title whowes/http content support feat(gax): allow non-JSON HttpContent and absolute request URLs in HttpRequestRunnable Aug 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
Image 0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@whowes whowes changed the title feat(gax): allow non-JSON HttpContent and absolute request URLs in HttpRequestRunnable feat(gax): allow non-JSON HttpContent and absolute request URLs in HttpRequestRunnable Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant