add to pypi - #43
Conversation
| from setuptools import setup | ||
| from setuptools import setup, find_packages | ||
|
|
||
| try: |
There was a problem hiding this comment.
Let this try/except stay?
There was a problem hiding this comment.
What is the point of the try/except?
There was a problem hiding this comment.
Messy permissions on some system can cause this to fail in hilarious ways. It doesn't matter much though.
I'm gonna switch this package to using flit for packaging if I get the time.
There was a problem hiding this comment.
I think you need to fix your permissions. Writing crappy software because someone doesn't have their system set up rioght is usually not a good idea. But given that you are the maintainer here, you are welcome to make the change yourself if you really think it is a good idea.
| ), | ||
| long_description=long_description, | ||
| url="https://github.com/getify/JSON.minify/tree/python", | ||
| url="https://github.com/fiduswriter/JSON.minify/tree/python", |
There was a problem hiding this comment.
You'll want to revert this line change before this merges. :P
There was a problem hiding this comment.
right. if you guys are willing to take over maintainership, we can move it all back into the getify repository. I just cannot have it point to that repo as long as I am listed as the maintainer but I don't have write access.
|
Sorry; I completely lost track of this. Thanks for doing this @johanneswilm! If you want it and @getify is fine with it, he can give you write access to the repo and you can maintain the package. Otherwise, I don't mind taking over the name and managing it. :) |
|
@pradyunsg Hey, yes, I would prefer for you to take over maintainership (I have too many other obligations already). If you give me your username on pypi, I can make the transfer. |
|
It's |
|
@pradyunsg Ok, great, I have added you as a package owner. Feel free to remove me once you have everything set up. |
|
I'll do it in a few hours. :) |
|
Closing due to #45 and https://pypi.org/project/JSON_minify/ . |
|
Sorry for the delay. Got swept in other stuff. |
|
@johanneswilm Could you look at https://pypi.org/manage/project/JSON_minify/collaboration/ and verify if I'm a project owner? |
|
@pradyunsg you are a manager so that you can push out releases. I stay myself also just to ensure that releases really do happen given that there has been a history of updates not coming through. |
|
Mind making me an owner? =) |
|
I actually made you an owner first. But then when you didn't release for another 3 weeks even though the code was ready and had written in that there was no pypi package, I took that position again. Given that you apparently don't use the package on pypi yourself, I think this current setup is quite OK, don't you think? We are a bunch of different projects who need a package like this and had been waiting for years for a similar package to finally update to python 3, and the administrator just stopped reacting. So now it would be good to avoid having the same thing happen here. |
I do this in my own free time. I did it when I found the free time to do so.
No, I don't. Anyway, if you want to stay on top of everything, you can just stay an owner. That said, I don't expect there to be any activity happening on this project and at the end of the day I don't really care enough to use my time to spend time elaborating the reasons for why I don't think so. I'm happy to let you take over maintenance of the PyPI project and remove me as a collaborator. |
Yes, and that's fine. But then you also surely understand that those who rely on this for something serious actually need to be able to make sure that the project doesn't just die on pypi, right?
Right. So that's another good reason why you probably shouldn't take full control of the package. You are welcome to continue as a manager though.
Ok, I can continue to maintain it there as I have been doing, Let me know if you want to be added again. |
Nope. It's easy enough to fork and maintain. I'd rather not digress though. :)
I'll be happy to step down.
👍 |
Right. But pypi maintainership is gone if the maintainer there is just unresponsive. Taht's what happened with the maintainer of a similar package. As for this package on pypi, the history is this:
So basically, I am a bit afraid of you just disappearing for a few years again. That's of course your right to do -- as you sid, you do this in your free time. It's just not acceptable for a production level project to depend on a maintainer who doesn't respond.That's why I will continue to have some control over the pypi package. I don;t understand why you need to be registered as package owner there when you don't really care enough to keep an updated package there. |
I don't. :) |
|
OK, seems like everything has been resolved. Locking this conversation so we don't digress any further. |
Hey,
given that there was no action on the part of @pradyunsg over the past two years [1] and we badly needed this, I have published the python package to pypi [2]. In order to fulfill the pypi maintenance requirements, I really needed write access, so I did that out of our fork for now. However, I really don't have any shares in this package, so if @pradyunsg, @tobeycarman, @ronichoudhury or @getify want to take over package maintainership, just let me know and I will happily transfer it to you.
[1] #21
[2] https://pypi.python.org/pypi/JSON_minify