Fix duplicate execution during bulk input on delegated command - #133
Merged
Conversation
Commands that delegate to other commands were passing the bulk input flag through to the subcommand. Since the command being delegated to is executed in a way that includes re-initialization, this would re-run the entire bulk input again for each entry in the bulk input file. To fix this, that flag is now filtered out when running each command for the bulk input file, to ensure that no such recursion is possible.
nidoran
approved these changes
Apr 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands that delegate to other commands were passing the bulk
input flag through to the subcommand. Since the command being
delegated to is executed in a way that includes re-initialization,
this would re-run the entire bulk input again for each entry in
the bulk input file. To fix this, that flag is now filtered out
when running each command for the bulk input file, to ensure that
no such recursion is possible.