Fix paging for events commands - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both events commands were not correctly paging through the API results and writing to output. To resolve this completely, a few different things needed to be addressed:
box eventsflags were adjusted to be more strict and ensure that the command always has either a stream position and limit, or a closed date-time rangebox-node-sdkwas pulled in, which contained a fix so the raw events JSON is returned instead of a useless iterator (since Node SDK iterators don't work with the event stream)box eventswas updated to use the raw JSON to manually page through the events results when a date range is specified (it just gives one page when a stream position is passed in, so the user can manually page if they want)box events:pollrequired a fix around how the CLI was consuming the events stream, because event emitters don't play nice with async functionsFixes #122