close
Skip to content

Add path parameter sanitization - #790

Merged
sujaygarlanka merged 5 commits into
masterfrom
path-sanitization
Apr 9, 2020
Merged

Add path parameter sanitization#790
sujaygarlanka merged 5 commits into
masterfrom
path-sanitization

Conversation

@sujaygarlanka

@sujaygarlanka sujaygarlanka commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

Added path parameter sanitization. So all IDs or other path parameters that should be numeric are checked to be numeric. If they are not, the SDK throws an error. In addition, all IDs that should be alphanumeric are checked to be alphanumeric. If they are not, the SDK throws an error.

@coveralls

coveralls commented Apr 8, 2020

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2163

  • 49 of 60 (81.67%) changed or added relevant lines in 8 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 65.554%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 2 5 40.0%
src/main/java/com/box/sdk/URLTemplate.java 28 36 77.78%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/BoxAPIRequest.java 2 63.51%
src/main/java/com/box/sdk/RealtimeServerConnection.java 3 80.0%
Totals Coverage Status
Change from base Build 2148: 0.01%
Covered Lines: 5498
Relevant Lines: 8387

💛 - Coveralls

Comment thread src/main/java/com/box/sdk/URLTemplate.java Outdated
Comment thread src/main/java/com/box/sdk/URLTemplate.java Outdated
Comment thread src/main/java/com/box/sdk/BoxFile.java
sujaygarlanka and others added 3 commits April 9, 2020 10:36
Co-Authored-By: Patrick Simon <patrick@box.com>
Co-Authored-By: Patrick Simon <patrick@box.com>
@sujaygarlanka
sujaygarlanka merged commit 1e3abcb into master Apr 9, 2020
@sujaygarlanka
sujaygarlanka deleted the path-sanitization branch April 9, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants