close
Skip to content

Update files.md to tag thumbnail code sample - #733

Merged
carycheng merged 3 commits into
box:masterfrom
cbetta:patch-1
Oct 18, 2019
Merged

Update files.md to tag thumbnail code sample#733
carycheng merged 3 commits into
box:masterfrom
cbetta:patch-1

Conversation

@cbetta

@cbetta cbetta commented Sep 11, 2019

Copy link
Copy Markdown

No description provided.

@boxcla

boxcla commented Sep 11, 2019

Copy link
Copy Markdown

Verified that @cbetta has signed the CLA. Thanks for the pull request!

@coveralls

coveralls commented Sep 11, 2019

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1955

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.205%

Totals Coverage Status
Change from base Build 1954: 0.0%
Covered Lines: 5322
Relevant Lines: 8162

💛 - Coveralls

@carycheng

Copy link
Copy Markdown

Hey @cbetta, looks good, curious about the format - should it be thumbnail or thumbnail_id? Wondering what the id refers to in this case, is it's just arbitrary then no worries, thanks!

@carycheng
carycheng self-requested a review September 11, 2019 21:20
@cbetta

cbetta commented Sep 12, 2019

Copy link
Copy Markdown
Author

Hey @carycheng, yes get_files_id_thumbnail_id is correct.

In general terms, we replace every variable in the URL with a generic id and replace every forward slash and dot into a _.

In this case, that means GET /files/:file_id/thumbnail.:extension becomes get_files_id_thumbnail_id. The last ID is the extension.

More on this here: https://confluence.inside-box.net/display/PLT/Sample+Tags

@carycheng
carycheng merged commit ca5e509 into box:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants