create set method for CanNonOwnerInvite - #700
Conversation
Sets whether or not the non-owners can invite collaborators to the folder.
|
Hi @Band-Aid, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks! |
|
CLA signed |
|
Verified that @Band-Aid has just signed the CLA. Thanks, and we look forward to your contribution. |
mattwiller
left a comment
There was a problem hiding this comment.
@Band-Aid Thank you for the pull request! It looks like the CI job is failing; please see my comments on the code for details. If you don't mind making the changes to get it passing, I can merge the PR.
| * | ||
| * @param isRestricted indicates whether there is collaboration restriction within enterprise. | ||
| */ | ||
| public void setIsCollaborationRestrictedToEnterprise(boolean isRestricted) { |
There was a problem hiding this comment.
CI is failing, I think because this method already exists:
/home/travis/build/box/box-java-sdk/src/main/java/com/box/sdk/BoxFolder.java:1302: error: method setIsCollaborationRestrictedToEnterprise(boolean) is already defined in class BoxFolder.Info
public void setIsCollaborationRestrictedToEnterprise(boolean isRestricted) {
^
Could you remove it and see if that fixes things?
There was a problem hiding this comment.
sorry about that don't know how that got passed my test build :(
removed duplicate code and also fixed typo in comments
There was a problem hiding this comment.
@mattwiller Any thoughts why CI is failing? Says some sort styling guide error
Also fixed typo in comments for setCanNonOwnersInvite
Pull Request Test Coverage Report for Build 1889
💛 - Coveralls |
|
@Band-Aid It looks like the linter wanted a space between the closing parenthesis and opening brace in the method signature; I went ahead and made the edit and merged the PR. We'll get this released in the upcoming version of the SDK in the next week! |
|
Hey @Band-Aid, Thank you for your contribution! We have release v2.33.0 of the sdk and your work is included in that! Again much appreciated and if you have any questions or feedback, please do not hesitate to reach out! |
Sets whether or not the non-owners can invite collaborators to the folder.