Wrong casting for response in BoxAPIResponse for BoxMetadataCascadePo… - #685
Merged
Conversation
|
Hi @carycheng, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks! |
Pull Request Test Coverage Report for Build 1832
💛 - Coveralls |
mattwiller
reviewed
Mar 4, 2019
| .add("conflict_resolution", conflictResolution); | ||
| request.setBody(requestJSON.toString()); | ||
| BoxJSONResponse response = (BoxJSONResponse) request.send(); | ||
| BoxAPIResponse response = request.send(); |
There was a problem hiding this comment.
If you're not using the result anyway, why have it at all? You could just do request.send() and throw away the result.
added 2 commits
March 4, 2019 10:56
…into metadata_cascade_patch
mattwiller
approved these changes
Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…licy
Unfortunately, I introduced a bug in BoxMetadataCascadePolicy.forceApply().
The issue being this API does not return a response body. However, I casted the return type, originally being BoxAPIResponse to BoxJSONResponse. This would then throw a casting exception.