close
Skip to content

Implement invite user to enterprise - #504

Merged
mattwiller merged 4 commits into
masterfrom
invite_to_enterprise
Feb 1, 2018
Merged

Implement invite user to enterprise#504
mattwiller merged 4 commits into
masterfrom
invite_to_enterprise

Conversation

@mattwiller

Copy link
Copy Markdown

No description provided.

@boxcla

boxcla commented Dec 21, 2017

Copy link
Copy Markdown

Verified that @mattwiller has signed the CLA. Thanks for the pull request!

@mattwiller

Copy link
Copy Markdown
Author

Fixes #61

Comment thread src/test/java/BoxInviteTest.java Outdated
/**
* {@link BoxInvite} related tests.
*/
public class BoxInviteTest {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add an integration test as this is a new api?

@mattwiller

Copy link
Copy Markdown
Author

@iamharish This would be kind of tricky to add integration tests for, since it involves setting up a user account that isn't in the enterprise. It's not easy to create that through the API today — certainly not in a way that would be easily repeatable. Do you have any ideas on how we could set up an end-to-end test for this?

@mattwiller
mattwiller merged commit ee292f3 into master Feb 1, 2018
@mattwiller
mattwiller deleted the invite_to_enterprise branch February 1, 2018 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants