Split function test refactor with failure and different success scena… - #690
Closed
SampathKumarAmex wants to merge 1 commit into
Closed
Split function test refactor with failure and different success scena…#690SampathKumarAmex wants to merge 1 commit into
SampathKumarAmex wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
=========================================
Coverage 55.59% 55.59%
- Complexity 10335 10336 +1
=========================================
Files 1059 1059
Lines 65045 65045
Branches 7399 7399
=========================================
+ Hits 36159 36161 +2
+ Misses 26337 26336 -1
+ Partials 2549 2548 -1
Continue to review full report at Codecov.
|
Contributor
|
Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split function unit test refactor with failure and different success scenarios.
Motivation and Context
Actually, it's good to further separate all the different variations in scenario #2. So that we will have feedback from all the tests in single execution (i.e. CI build) even when one of the test scenarios fail. Also, it improves the readability and help to understand the scenarios better. Having said that, I haven't done that as part of this PR.
@Testannotation. This is to make the JUnit 5 usage consistent in this test classHow Has This Been Tested?
n/a - Unit test refactoring
Screenshots (if appropriate):
Types of changes
Checklist: