close
Skip to content

Increase visible lines of code in IfController and WhileController - #665

Closed
dgetzlaf wants to merge 1 commit into
apache:masterfrom
dgetzlaf:more-visible-lines-for-if-and-whilecontroller
Closed

Increase visible lines of code in IfController and WhileController#665
dgetzlaf wants to merge 1 commit into
apache:masterfrom
dgetzlaf:more-visible-lines-for-if-and-whilecontroller

Conversation

@dgetzlaf

@dgetzlaf dgetzlaf commented May 19, 2021

Copy link
Copy Markdown
Contributor

Increase the visible lines of code in IfController and WhileController from 5 to 15 to write more complex statements.

@codecov-commenter

codecov-commenter commented May 19, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.35%. Comparing base (25ab888) to head (2052f5e).
⚠️ Report is 1186 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #665      +/-   ##
============================================
- Coverage     55.46%   55.35%   -0.12%     
- Complexity    10181    10193      +12     
============================================
  Files          1046     1046              
  Lines         64147    64437     +290     
  Branches       7265     7309      +44     
============================================
+ Hits          35580    35668      +88     
- Misses        26060    26263     +203     
+ Partials       2507     2506       -1     
Files with missing lines Coverage Δ
...g/apache/jmeter/control/gui/IfControllerPanel.java 68.00% <100.00%> (ø)
.../apache/jmeter/control/gui/WhileControllerGui.java 78.12% <100.00%> (ø)

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ab888...2052f5e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dgetzlaf dgetzlaf changed the title Increase visible lines of code in IfControllerPanel and WhileControll… Increase visible lines of code in IfController and WhileController May 19, 2021
@asfgit asfgit closed this in 7842529 May 23, 2021
@FSchumacher

Copy link
Copy Markdown
Contributor

Thanks for the patch.
I have chosen a different path, but I hope, that you still like the result.

@dgetzlaf

Copy link
Copy Markdown
Contributor Author

@FSchumacher thank you very much for implementing a nice fix ! :)

@dgetzlaf
dgetzlaf deleted the more-visible-lines-for-if-and-whilecontroller branch May 24, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants