fix: restore public static final String references to literals for backward compatibility - #5988
Merged
Conversation
…ckward compatibility Previously, TestElement.NAME and similar constants were coded as literals, and it was possible to use those references in annotation values. If the replace literals with method calls, then it would be impossible to use the fields in annotation values. So the static fields are reverted to literals. This partially reverts commits like apache#678,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously, TestElement.NAME and similar constants were coded as literals, and it was possible to use those references in annotation values.
If the replace literals with method calls, then it would be impossible to use the fields in annotation values.
So the static fields are reverted to literals.
This partially reverts commits like #678,