close
Skip to content

Removed the http4client.retain_max_body_size property mentions - #578

Merged
pmouawad merged 1 commit into
apache:masterfrom
kkalinin:remove_max_body_retain_size
Oct 1, 2020
Merged

Removed the http4client.retain_max_body_size property mentions#578
pmouawad merged 1 commit into
apache:masterfrom
kkalinin:remove_max_body_retain_size

Conversation

@kkalinin

@kkalinin kkalinin commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

Description

I've removed the http4client.retain_max_body_size property mentions from documentation and jmeter.properties file.

Motivation and Context

The property is not used anymore and just confuses users.

How Has This Been Tested?

No need to test, only text files modified`

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the [code style][style-guide] of this project.
  • I have updated the documentation accordingly.

@vlsi

vlsi commented Apr 3, 2020

Copy link
Copy Markdown
Collaborator

@pmouawad , I see the property was removed in 97cc6f4
Do you think it should be completely removed or should it be re-implemented somehow?

@pmouawad

pmouawad commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

@pmouawad , I see the property was removed in 97cc6f4
Do you think it should be completely removed or should it be re-implemented somehow?

I would prefer to have it re-implemented somehow

@pmouawad
pmouawad merged commit b17ac36 into apache:master Oct 1, 2020
kkalinin added a commit to kkalinin/jmeter that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants