Display an info message, when no JavaFX is found and RenderInBrowser … - #408
Closed
FSchumacher wants to merge 1 commit into
Closed
Display an info message, when no JavaFX is found and RenderInBrowser …#408FSchumacher wants to merge 1 commit into
FSchumacher wants to merge 1 commit into
Conversation
…is used Currently we will log a full exception stack trace in warning leve, when no JavaFX was found and RenderInBrowser is initialized. Reduce the log level to info and display a short message that the user should install JavaFX in their Java environment, if they want to use the renderer.
Codecov Report
@@ Coverage Diff @@
## trunk #408 +/- ##
============================================
+ Coverage 58.58% 58.58% +<.01%
- Complexity 10616 10618 +2
============================================
Files 1193 1193
Lines 75957 75961 +4
Branches 7343 7344 +1
============================================
+ Hits 44499 44505 +6
Misses 28953 28953
+ Partials 2505 2503 -2
Continue to review full report at Codecov.
|
Contributor
|
+1 Should you test «.javafx. » instead of only javafx? Thanks |
Contributor
Author
|
The message from a |
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
This will happen when JavaFX is not found while looking for the RenderInBrowser component. Closes apache#408 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843812 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 36bc5f8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…is used
Description
Currently we will log a full exception stack trace in warning level, when no
JavaFX was found and
RenderInBrowseris initialized.Reduce the log level to info and display a short message that the user should
install JavaFX in their Java environment, if they want to use the renderer.
Motivation and Context
The user is probably scared when an exception stack trace is shown in their log file. This change should help the user to take the needed steps more easily.
How Has This Been Tested?
Tested through GUI.
Types of changes
Checklist: