fix(geo): tolerate singular view transform when chart size is zero - #21707
Merged
plainheart merged 2 commits intoJul 26, 2026
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
plainheart
force-pushed
the
fix-geo-zero-size-invert-null
branch
from
July 26, 2026 07:05
6381d33 to
1ec3462
Compare
plainheart
approved these changes
Jul 26, 2026
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes the
TypeError: Cannot read properties of null (reading '0')thrown by every geo/map chart whose size is 0×0 (e.g. a container hidden withdisplay: none) — a regression introduced in 6.1.0.Fixed issues
Details
Before: What was the problem?
With a zero-sized view rect the overall view transform has zero scale, so its determinant is 0 and zrender's
matrix.invert()returnsnullwithout writingout.viewCoordSysUpdateOverallTranspassed that return value tolegacyCopyOverallTransunguarded, wherematrixCopy(target.invTransform, null)dereferencesnull[0].Before 6.1.0, the equivalent code (
View.prototype._updateTransform) ignoredinvert()'s return value —invTransformsimply kept its previous contents — so zero-sized geo charts were tolerated. Since the failure happens inside the update pipeline, in real apps it re-throws on every animation frame until the chart is disposed.After: How does it behave after the fixing?
legacyCopyOverallTransskips the inverse copy whenmatrixInvertreturnednull, keeping the last inverse — the same semantics as before 6.1.0 (and the same as the existingmatrixInvert(viewInner.mtRawInv, mtRaw)call in this file, whose return value is likewise ignored). Zero-sized geo/map charts render without throwing; a regression unit test is included (fails before the fix, passes after).Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information