fix(tree): fix tree update error with animation and without animation - #18491
Open
linghaoSu wants to merge 2 commits into
Open
fix(tree): fix tree update error with animation and without animation#18491linghaoSu wants to merge 2 commits into
linghaoSu wants to merge 2 commits into
Conversation
|
Thanks for your contribution! |
This was referenced Apr 11, 2023
Ovilia
requested changes
Jun 25, 2023
Ovilia
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your PR! This fixes an important bug of Tree Series.
|
@Ovilia When will this PR be reviewed? It's been almost a year now and the bug persists. |
mosk
approved these changes
Sep 22, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
polyline, with animation on, to filter out nodes that are about to exit, and clearsourceEdgeif the number of remaining nodes is 0tree, with animation off, pass the current node inremoveNodeEdgesince the current node is immediately deleted, making it impossible to get the current node by dataIndex.Fixed issues
Details
Before: What was the problem?
polyline, when a child node is removed by updating the node, the line is not removedtrees, when collapsing a node with animation off, lines will be left behindAfter: How does it behave after the fixing?
polyline, when a child node is removed by updating the node, the lines will be removedtrees, collapse the node with the animation off, no lines will be leftDocument Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information