close
Skip to content

Add ENU ECEF target coordinate calculation (geodesy) - #15056

Open
deniztunccekic wants to merge 8 commits into
TheAlgorithms:masterfrom
deniztunccekic:master
Open

Add ENU ECEF target coordinate calculation (geodesy)#15056
deniztunccekic wants to merge 8 commits into
TheAlgorithms:masterfrom
deniztunccekic:master

Conversation

@deniztunccekic

Copy link
Copy Markdown

Describe your change:

This PR adds an algorithm to calculate target geodetic coordinates based on radar measurements (Azimuth, Range, Elevation). It converts Geodetic coordinates to Earth-Centered, Earth-Fixed (ECEF) Cartesian coordinates and applies Bowring's method for precise conversion back to Geodetic.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names labels Aug 20, 2026

@algorithms-keeper algorithms-keeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.


def ecef_to_geodetic(x: float, y: float, z: float) -> tuple[float, float, float]:
"""
Converts Earth-Centered, Earth-Fixed (ECEF) coordinates to

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: x

Please provide descriptive name for the parameter: y

Please provide descriptive name for the parameter: z

def enu_to_ecef(
e: float, n: float, u: float, ref_lat_deg: float, ref_lon_deg: float
) -> tuple[float, float, float]:
"""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: e

Please provide descriptive name for the parameter: n

Please provide descriptive name for the parameter: u

@algorithms-keeper algorithms-keeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread geodesy/radar_target_calculation.py Outdated
return x, y, z


def ecef_to_geodetic(x: float, y: float, z: float) -> tuple[float, float, float]:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: x

Please provide descriptive name for the parameter: y

Please provide descriptive name for the parameter: z

Comment thread geodesy/radar_target_calculation.py Outdated


def enu_to_ecef(
e: float, n: float, u: float, ref_lat_deg: float, ref_lon_deg: float

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: e

Please provide descriptive name for the parameter: n

Please provide descriptive name for the parameter: u

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Aug 20, 2026
@algorithms-keeper algorithms-keeper Bot removed the require descriptive names This PR needs descriptive function and/or variable names label Aug 20, 2026
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant