You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new SpotBugs exclusion uses the regex ~org.openqa.selenium.remote.RemoteWebDriver.*, which
also matches other classes with the same prefix (e.g., RemoteWebDriverBuilder) and will suppress
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE warnings beyond the intended target. This reduces SpotBugs’
ability to flag null-dereference regressions in those other matched classes.
The SpotBugs filter introduces a prefix regex for RemoteWebDriver.*; the repository also contains
RemoteWebDriverBuilder, which matches that regex, demonstrating the suppression is broader than
just the intended RemoteWebDriver class/inners.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`java/spotbugs-excludes.xml` adds a regex suppression for `~org.openqa.selenium.remote.RemoteWebDriver.*`, which matches any class whose FQCN starts with `org.openqa.selenium.remote.RemoteWebDriver` (including `RemoteWebDriverBuilder`). This broadens the suppression scope and can unintentionally hide future SpotBugs NPE warnings.
### Issue Context
Evidence that the regex matches more than intended:
- Exclusion: `~org.openqa.selenium.remote.RemoteWebDriver.*`
- Existing class: `org.openqa.selenium.remote.RemoteWebDriverBuilder`
### Fix Focus Areas
- java/spotbugs-excludes.xml[157-160]
### Suggested change
Replace the broad prefix regex with either:
1) An exact class match for the top-level class, plus a separate regex for inner classes (using `$`), or
2) A single anchored regex like:
- `~org\.openqa\.selenium\.remote\.RemoteWebDriver(\$.*)?$`
Apply the same tightening pattern to other newly-added `~...*` remote suppressions if they were also intended to only cover the exact class + its inner classes (not same-prefix siblings).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
The new exclusion ~org.openqa.selenium.remote.http.jdk.JdkHttpClient.* suppresses
USO_UNSAFE_OBJECT_SYNCHRONIZATION for any class beginning with JdkHttpClient, not just
JdkHttpClient itself. This broad selector can unintentionally hide synchronization warnings in
other same-prefix classes (present or future), reducing SpotBugs signal quality.
The new SpotBugs filter rule uses a JdkHttpClient.* prefix regex; the repo contains another class
with that same prefix (JdkHttpClientTest), showing the exclusion matches more than just
JdkHttpClient.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`java/spotbugs-excludes.xml` adds `~org.openqa.selenium.remote.http.jdk.JdkHttpClient.*`, which matches any class whose FQCN starts with `...JdkHttpClient` (not just the exact `JdkHttpClient` class). This broadens the suppression scope and can hide real `USO_UNSAFE_OBJECT_SYNCHRONIZATION` warnings in other same-prefix types.
### Issue Context
There is at least one additional same-prefix class in the repo (`JdkHttpClientTest`), demonstrating the selector is not constrained to just the intended class name.
### Fix Focus Areas
- java/spotbugs-excludes.xml[287-290]
### Suggested change
Prefer an exact class match:
- `<Class name="org.openqa.selenium.remote.http.jdk.JdkHttpClient"/>`
If the intent was to include inner classes only, add a separate regex explicitly for inners:
- `~org\.openqa\.selenium\.remote\.http\.jdk\.JdkHttpClient\$.*`
(or use a single anchored regex: `~org\.openqa\.selenium\.remote\.http\.jdk\.JdkHttpClient(\$.*)?$`).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
The new SpotBugs exclusion uses the regex ~org.openqa.selenium.remote.RemoteWebDriver.*, which
also matches other classes with the same prefix (e.g., RemoteWebDriverBuilder) and will suppress
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE warnings beyond the intended target. This reduces SpotBugs’
ability to flag null-dereference regressions in those other matched classes.
The SpotBugs filter introduces a prefix regex for RemoteWebDriver.*; the repository also contains
RemoteWebDriverBuilder, which matches that regex, demonstrating the suppression is broader than
just the intended RemoteWebDriver class/inners.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`java/spotbugs-excludes.xml` adds a regex suppression for `~org.openqa.selenium.remote.RemoteWebDriver.*`, which matches any class whose FQCN starts with `org.openqa.selenium.remote.RemoteWebDriver` (including `RemoteWebDriverBuilder`). This broadens the suppression scope and can unintentionally hide future SpotBugs NPE warnings.
### Issue Context
Evidence that the regex matches more than intended:
- Exclusion: `~org.openqa.selenium.remote.RemoteWebDriver.*`
- Existing class: `org.openqa.selenium.remote.RemoteWebDriverBuilder`
### Fix Focus Areas
- java/spotbugs-excludes.xml[157-160]
### Suggested change
Replace the broad prefix regex with either:
1) An exact class match for the top-level class, plus a separate regex for inner classes (using `$`), or
2) A single anchored regex like:
- `~org\.openqa\.selenium\.remote\.RemoteWebDriver(\$.*)?$`
Apply the same tightening pattern to other newly-added `~...*` remote suppressions if they were also intended to only cover the exact class + its inner classes (not same-prefix siblings).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
The new exclusion ~org.openqa.selenium.remote.http.jdk.JdkHttpClient.* suppresses
USO_UNSAFE_OBJECT_SYNCHRONIZATION for any class beginning with JdkHttpClient, not just
JdkHttpClient itself. This broad selector can unintentionally hide synchronization warnings in
other same-prefix classes (present or future), reducing SpotBugs signal quality.
The new SpotBugs filter rule uses a JdkHttpClient.* prefix regex; the repo contains another class
with that same prefix (JdkHttpClientTest), showing the exclusion matches more than just
JdkHttpClient.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`java/spotbugs-excludes.xml` adds `~org.openqa.selenium.remote.http.jdk.JdkHttpClient.*`, which matches any class whose FQCN starts with `...JdkHttpClient` (not just the exact `JdkHttpClient` class). This broadens the suppression scope and can hide real `USO_UNSAFE_OBJECT_SYNCHRONIZATION` warnings in other same-prefix types.
### Issue Context
There is at least one additional same-prefix class in the repo (`JdkHttpClientTest`), demonstrating the selector is not constrained to just the intended class name.
### Fix Focus Areas
- java/spotbugs-excludes.xml[287-290]
### Suggested change
Prefer an exact class match:
- `<Class name="org.openqa.selenium.remote.http.jdk.JdkHttpClient"/>`
If the intent was to include inner classes only, add a separate regex explicitly for inners:
- `~org\.openqa\.selenium\.remote\.http\.jdk\.JdkHttpClient\$.*`
(or use a single anchored regex: `~org\.openqa\.selenium\.remote\.http\.jdk\.JdkHttpClient(\$.*)?$`).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-buildIncludes scripting, bazel and CI integrationsB-devtoolsIncludes everything BiDi or Chrome DevTools relatedB-gridEverything grid and server relatedB-managerSelenium ManagerC-buildC-dotnet.NET BindingsC-javaJava BindingsC-nodejsJavaScript BindingsC-pyPython BindingsC-rbRuby BindingsC-rustRust code is mostly Selenium Manager
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Info
Updates Applied
Auto-generated by release-preparation workflow