close
Skip to content

feat: add cyan accent variant for RareStyle - #781

Merged
loathingKernel merged 2 commits into
RareDevs:mainfrom
alessio-attilio:feature/accent-colorstyle
Aug 20, 2026
Merged

feat: add cyan accent variant for RareStyle#781
loathingKernel merged 2 commits into
RareDevs:mainfrom
alessio-attilio:feature/accent-colorstyle

Conversation

@alessio-attilio

Copy link
Copy Markdown
Contributor

Adds a selectable cyan accent variant for the RareStyle theme, applied at runtime by recoloring its purple accent colors.
The variant is exposed as an "Accent color" option in the Interface settings and defaults to the existing purple.

@alessio-attilio

Copy link
Copy Markdown
Contributor Author
c

@alessio-attilio
alessio-attilio force-pushed the feature/accent-colorstyle branch from 25e3a70 to 39758b1 Compare August 19, 2026 20:53
@alessio-attilio
alessio-attilio marked this pull request as draft August 19, 2026 20:56
@alessio-attilio
alessio-attilio force-pushed the feature/accent-colorstyle branch from 39758b1 to 94a495b Compare August 19, 2026 20:56
@loathingKernel

loathingKernel commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

I cannot describe how bad this way of doing it is. I don't even know where to begin with it.

Make a copy of the theme, change the name, the colors or whatever else you please in the new theme, update any static images, such as the check box checkmarks etc to reflect your preferred color, add the theme to the list of themes, done... this has to be a joke, I cannot imagine why when there is already an example in the code of doing exactly this, the ChildOfMetropolis theme, you would add something completely different. There is a way to do this already and there is an example of it, we do not need a third thing.

The last time you made a similar PR was not merged because the theme was not complete, and because it was touching things outside of itself.

@alessio-attilio

Copy link
Copy Markdown
Contributor Author

I liked the idea of creating a variant of RareStyle using cyan. Since I wanted to create a variant that only changed the color, I thought I'd modify the scheme. Can't I just add the ColorScheme?

Also, why are there all these changes in the PR?

@alessio-attilio
alessio-attilio force-pushed the feature/accent-colorstyle branch 2 times, most recently from 0429880 to 1613166 Compare August 20, 2026 09:16
@alessio-attilio
alessio-attilio force-pushed the feature/accent-colorstyle branch from 1613166 to fed3a28 Compare August 20, 2026 09:35
@alessio-attilio
alessio-attilio marked this pull request as ready for review August 20, 2026 09:35
@loathingKernel

Copy link
Copy Markdown
Contributor

Please change the name to something new and unique to it, but other than that, this is exactly how it''s meant to add a new theme, thanks for updating it.

@alessio-attilio

Copy link
Copy Markdown
Contributor Author

Do you like "cyanotic"?

@loathingKernel

Copy link
Copy Markdown
Contributor

It's fine, I guess, I just didn't want it to have Rare in it. The existing style is named like that because it is the default

@loathingKernel
loathingKernel merged commit cd51e3f into RareDevs:main Aug 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants