Johnfreeman/trgdataformats issue59 review impl - #106
Open
jcfreeman2 wants to merge 5 commits into
Open
Conversation
added 4 commits
July 14, 2026 16:22
…e to reflect change in trgdataformats
…to reflect use of C++20 code in trgdataformats headers
…ides to convert the trigger candidate type enum into a string
…erlay's new set_inputs function
jcfreeman2
marked this pull request as ready for review
August 11, 2026 21:50
4 tasks
… to and from the trgdataformats overlays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a change needed so this repo compiles against the updates to
trgdataformatsin DUNE-DAQ/trgdataformats#61. It should not be merged before thetrgdataformatsPR is merged. Astrgdataformatswill now include code which compiles under C++20 and not C++17, fortriggeralgsto compile its standard will also need to be bumped to C++20.A successful test build (
TDFRFD_DEV_260811_A9, https://github.com/DUNE-DAQ/daq-release/actions/runs/31514886523) was performed using this branch.Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))