Ingress network should not be attachable#2523
Conversation
Ingress network is a special network used only to expose ports. For this reason the network cannot be explicitly attached during service create or service update Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
52ec1b9 to
610e268
Compare
Codecov Report
@@ Coverage Diff @@
## master #2523 +/- ##
==========================================
- Coverage 61.35% 61.33% -0.02%
==========================================
Files 133 133
Lines 21724 21726 +2
==========================================
- Hits 13328 13325 -3
- Misses 6951 6959 +8
+ Partials 1445 1442 -3 |
|
So, wait, was this really just a case of the validation logic for networks looking at the wrong field? |
anshulpundir
left a comment
There was a problem hiding this comment.
Will this break an existing workflows in moby or UCP ?
|
@dperny yep looks like for this specific case the deprecation of the field, forgot to update the spec validation with the proper new designated field for what concerns the ServiceCreate call. For the ServiceUpdate instead there was no check at all. @anshulpundir there should not be any existing workflows that where explicitly attaching the ingress network, so if there were any they were already broken |
|
LGTM. Turns out because this is just updating the check of a deprecated field to a check of a current one, I'm gonna merge off just our two LGTMs. |
Ingress network is a special network used only to expose
ports. For this reason the network cannot be explicitly
attached during service create or service update
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com