Drop Python 2 support - #346
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1186 1169 -17
Branches 47 46 -1
=========================================
- Hits 1186 1169 -17
|
bluetech
force-pushed
the
drop-py2
branch
2 times, most recently
from
August 25, 2021 10:40
ffa92eb to
a325e38
Compare
pquentin
requested changes
Aug 25, 2021
pquentin
approved these changes
Aug 25, 2021
pquentin
left a comment
Member
There was a problem hiding this comment.
Thanks! Can you please add a news fragment?
Member
Author
|
I added a news fragment. |
Member
|
Thanks! I had difficulties updating the required checks from my phone, hence the delay. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #341, this drops Python 2 support. There's not big advantage to it, just makes the code a bit nicer (the typing in particular).