close
Skip to content

test on py 3.10 - #327

Merged
pquentin merged 7 commits into
python-trio:masterfrom
graingert:test-on-py310
Jun 8, 2021
Merged

pquentin merged 7 commits into
python-trio:masterfrom
graingert:test-on-py310

Conversation

@graingert

Copy link
Copy Markdown
Member

No description provided.

@pquentin

pquentin commented Jun 8, 2021

Copy link
Copy Markdown
Member

I'm OK with removing Python 2.7 support, we can always use older versions of trustme for urllib3 1.x.

(But don't bother doing it here unless it actually helps.)

Comment thread tests/test_trustme.py Outdated
@graingert

Copy link
Copy Markdown
Member Author

@pquentin looks like codecov is broken?

@graingert
graingert requested a review from pquentin June 8, 2021 13:40
@graingert graingert closed this Jun 8, 2021
@graingert graingert reopened this Jun 8, 2021
Comment thread ci.sh Outdated
@codecov

codecov Bot commented Jun 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #327 (6abfddd) into master (e3ac2d6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #327   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1160      1166    +6     
  Branches        48        48           
=========================================
+ Hits          1160      1166    +6     
Impacted Files Coverage Δ
trustme/tests/test_trustme.py 100.00% <0.00%> (ø)
a/trustme/trustme/tests/test_trustme.py 100.00% <0.00%> (ø)
.../runner/work/trustme/trustme/tests/test_trustme.py 100.00% <0.00%> (ø)

Comment thread ci.sh Outdated
@graingert graingert closed this Jun 8, 2021
@graingert graingert reopened this Jun 8, 2021

@pquentin pquentin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder if dependabot will pick up the py3 requirements.

We'll need to update the classifiers, but that can happen in another PR.

@pquentin
pquentin merged commit 8767902 into python-trio:master Jun 8, 2021
@graingert
graingert deleted the test-on-py310 branch June 8, 2021 17:22
@pquentin

pquentin commented Jun 8, 2021

Copy link
Copy Markdown
Member

I released this as part of 0.8.0: https://pypi.org/project/trustme/0.8.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants