Improve the error message when GADT parameter variance cannot be checked#13663
Merged
Conversation
gasche
approved these changes
Dec 8, 2024
Member
There was a problem hiding this comment.
I believe that this is correct and makes for a nice improvement to the error message.
Before we go ahead and merge, a quick look from @Octachron on at least the error message (and its use of ordinal numbers, etc.) would be nice, I wonder if he has opinions on how things should be done.
Octachron
reviewed
Dec 8, 2024
Octachron
reviewed
Dec 8, 2024
Octachron
reviewed
Dec 8, 2024
Octachron
reviewed
Dec 8, 2024
Octachron
reviewed
Dec 8, 2024
Member
|
All review comments have been addressed, merging! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.