[parser][SR-510] add diagnose for non-expr case raw value#931
Closed
dduan wants to merge 2 commits intoswiftlang:masterfrom
Closed
[parser][SR-510] add diagnose for non-expr case raw value#931dduan wants to merge 2 commits intoswiftlang:masterfrom
dduan wants to merge 2 commits intoswiftlang:masterfrom
Conversation
When a `case`'s raw value is not considered as a valid expression, generate a diagnose instead of silently quite. Previously this gets a silent exit. This change resolves [SR-510](https://bugs.swift.org/browse/SR-510).
Contributor
|
Just wanted to mention we're having a discussion about this in the attached bug report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
case's raw value is not considered as a valid expression, generate a diagnose instead of silently quite.This resolves SR-510