close
Skip to content

[stdlib] Fix a race#7183

Merged
swift-ci merged 1 commit intomasterfrom
rdar-25398370
May 19, 2017
Merged

[stdlib] Fix a race#7183
swift-ci merged 1 commit intomasterfrom
rdar-25398370

Conversation

@dabrahams
Copy link
Copy Markdown
Contributor

@dabrahams dabrahams commented Feb 1, 2017 •
edited
Loading

Lock-free programming is almost always a bug.
Fixes rdar://25398370 Data Race in StringBuffer.append (found by TSan)

@dabrahams
Copy link
Copy Markdown
Contributor Author

dabrahams commented Feb 1, 2017

@swift-ci Please smoke test and merge

@dabrahams dabrahams force-pushed the rdar-25398370 branch 2 times, most recently from 2450bc2 to 1040374 Compare February 9, 2017 01:10
@dabrahams
Copy link
Copy Markdown
Contributor Author

dabrahams commented Feb 9, 2017

@swift-ci Please test and merge

@airspeedswift
Copy link
Copy Markdown
Member

airspeedswift commented Feb 12, 2017

@swift-ci Please test

@swift-ci
Copy link
Copy Markdown
Contributor

swift-ci commented Feb 12, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 28c32f0
Test requested by - @airspeedswift

@swift-ci
Copy link
Copy Markdown
Contributor

swift-ci commented Feb 12, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 28c32f0
Test requested by - @airspeedswift

@dabrahams
Copy link
Copy Markdown
Contributor Author

dabrahams commented Mar 1, 2017

@swift-ci Please smoke test

@dabrahams
Copy link
Copy Markdown
Contributor Author

dabrahams commented Mar 1, 2017

Broken debugInfo causing Linux smoke test to fail reported in rdar://30793147

@adrian-prantl
Copy link
Copy Markdown
Contributor

adrian-prantl commented Mar 2, 2017

@swift-ci please test

@swift-ci
Copy link
Copy Markdown
Contributor

swift-ci commented Mar 2, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 1040374
Test requested by - @adrian-prantl

@CodaFi
Copy link
Copy Markdown
Contributor

CodaFi commented Apr 27, 2017

@swift-ci please test

@swift-ci
Copy link
Copy Markdown
Contributor

swift-ci commented Apr 27, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 1040374
Test requested by - @CodaFi

@swift-ci
Copy link
Copy Markdown
Contributor

swift-ci commented Apr 27, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 1040374
Test requested by - @CodaFi

[stdlib] Fix a race
fd30b72 
Lock-free programming is almost always a bug.
Fixes <rdar://25398370> Data Race in StringBuffer.append (found by TSan)
@dabrahams
Copy link
Copy Markdown
Contributor Author

dabrahams commented May 18, 2017

@swift-ci Please test and merge

@swift-ci swift-ci merged commit 32b4e56 into master May 19, 2017
@jrose-apple jrose-apple deleted the rdar-25398370 branch November 29, 2017 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dabrahams @airspeedswift @swift-ci @adrian-prantl @CodaFi