[Type checker] Don't infer 'dynamic' for 'let' variables or within final classes#4875
Merged
tkremenek merged 1 commit intoswiftlang:swift-3.0-branchfrom Sep 20, 2016
Merged
Conversation
…nal classes. The 'dynamic' inference would infer 'dynamic' in places where it would also infer 'final', leading to a diagnostic error: a declaration cannot be both 'final' and 'dynamic' with no source location information. Don't infer 'dynamic' in such places. Fixes SR-993 / rdar://problem/20449627. (cherry picked from commit 8166126)
Member
Author
|
@swift-ci please test |
Member
Author
|
@jrose-apple please review |
Contributor
|
Does this mean a static let in an extension can't be |
Member
Author
|
A static let in an extension can by |
Contributor
|
Oh, wait, right. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'dynamic' inference would infer 'dynamic' in places where it would
also infer 'final', leading to a diagnostic
error: a declaration cannot be both 'final' and 'dynamic'
with no source location information. Don't infer 'dynamic' in such
places.
Resolves SR-993 / rdar://problem/20449627
(cherry picked from commit 8166126)