[gardening] Add newline to end of header to fix warnings.#26650
Closed
gregomni wants to merge 1 commit intoswiftlang:masterfrom
Closed
[gardening] Add newline to end of header to fix warnings.#26650gregomni wants to merge 1 commit intoswiftlang:masterfrom
gregomni wants to merge 1 commit intoswiftlang:masterfrom
Conversation
Contributor
Author
|
@swift-ci Please smoke test and merge. |
Contributor
|
I think we've explicitly said we're not interested in this warning in the past… |
Contributor
Author
|
@jrose-apple Ok! How do you feel about explicitly turning the warning off in compiler flags? And is this sort of thing documented beyond the llvm coding style guide (which I don't think mentions this particular thing)? |
Contributor
|
I thought we had turned it off, but I don't see anything about -W[no-]newline-eof in our configuration. I agree that we should explicitly turn it off if we don't want to care about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.