Closure reflection#2452
Closed
slavapestov wants to merge 8 commits intoswiftlang:masterfrom
Closed
Conversation
Contributor
Author
|
@swift-ci Please test |
Remote metadata for closure contexts points to a capture descriptor. We have a local copy of all capture descriptors. Translate the address by recording the local and remote start address of reflection metadata.
Just drop the representation for now.
This adds various MetadataReader methods to support closure layout: - Reading generic arguments from metadata - Reading parent metadata - Reading capture descriptor from heap metadata To a large extent, this is not currently taken advantage of, because SILGen always wraps address-only captures in SIL box types. Tests are in the next patch.
0436633 to
d96ee50
Compare
…nce() Also add end-to-end tests for this finally, and fix a bug in the SwiftReflectionTest library where we would give up on an module completely if it did not have a field metadata section. This is of course wrong if the module defines closures but not nominal types.
d96ee50 to
4518888
Compare
Contributor
Author
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.