Fix GH-21927: Use-after-free of self-freeing MultipleIterator children.#21933
Closed
devnexen wants to merge 1 commit intophp:PHP-8.4from
Closed
Fix GH-21927: Use-after-free of self-freeing MultipleIterator children.#21933devnexen wants to merge 1 commit intophp:PHP-8.4from
devnexen wants to merge 1 commit intophp:PHP-8.4from
Conversation
…dren. Add a refcount on the child iterator across rewind/next/valid/current/key calls so user methods can detach themselves without freeing the object mid-call.
Girgias
approved these changes
May 4, 2026
Member
Girgias
left a comment
There was a problem hiding this comment.
Sure, MultipleIterator is a mess anyway
Member
|
Didn't we agree not to merge fuzzer issues into stable branches? |
Member
Author
|
I did not know it originated from fuzzer findings, do you want me to revert ? |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a refcount on the child iterator across rewind/next/valid/current/key calls so user methods can detach themselves without freeing the object mid-call.