New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyper Sessions restoration #945
base: master
Are you sure you want to change the base?
Conversation
7bf0333
to
3706c36
Compare
|
+1 please add this fast ;D |
|
@ivands Still have a few glitch! But working on it! |
d78027b
to
c7defe2
Compare
10c65c6
to
60dc986
Compare
868e69d
to
d6f9f92
Compare
|
Any news? |
|
We're going to be revisiting this PR very soon! |
|
Yeah indeed. Engineering studies took a toll on me haven't had much time lately to dedicate any time on anything except studies. Life happens you know. Much love. |
|
Session ended. Can start coding again! |
|
Thread started on spectrum. thread |
|
Any news since the last comment @ppot ? |
|
@VinceBT I started a thread for this feature, but nobody answered yet! |
|
@rauchg Any take on how you would see session restoration? |
|
@chabou, @rauchg While trying to make a session restoration plugin. I came across this problem. Since I can't share a state between and I can't have a global state residing inside my plugin. The reason is since we decouple the backend and the front-end. While I can listed to Each window will have one instance of the recorder. So how would we share this state between the two. The ideal way would be to listed to the In order to have this possibility we could separate the
One hacky way, which is code-smelling would be to have a stored state in a local file and make I am open for comment and suggestions. |
|
Have the same feature request |
Reading this issue gave me flashbacks: I implemented session save/restore in Firefox 2 in 2006. It basically worked the way you describe here. 12 years later, Mozilla is almost finished making that code not slow ( Off-by-default-until-fast is a nice balance between performance and protection, if that's easier to swallow than some interim perf hit. But no protection option leaves us developers living in fear |
|
If not to restore sessions, is it currently possible to create some predefined (config layout) on the app start, so it would open needed tabs and split pane and need? |
I use hypercwd and set initialWorkingDirectory to my desire |
|
@caina-jumia I too use it, but I need tabs and split panes setup. |
|
@ppot worth keeping this open or will you make a new one when you work on this again anyway? |
|
@Stanzilla worth keep it open. I'm exploring the rust binding for speed |
|
Oops miss clicked, alright then! |
|
Is this dead? |
|
Hey, @ppot! Have you any progress in this task? Appositely, thank you a lot for you work! |
|
This seems almost done, right ? |
No |
|
Hi reviewers, any status on this feature ? |
|
Hi Guys, I just want to understand the request as I'm working on something myself. Is the request to save & restore tabs, panes, windows, positions and cwd for each? Have I missed anything? |
no updates right now, though it might be doable now as we've started releasing again and so the development should pick up a bit.
that's all I guess, you can also include restoring terminal content using xterm serialization addon if you want. |
... From what I can see so far the serialization addon saves out the terminal buffer, not yet sure how that would be useful for restoring it because ultimately I assume the goal would be to restore the shell session which is a different issue especially the command state and process state in the shell. I've already handled capture and save options of terminal content anyway and gone a little further than the serialisation addon. Any ideas on approaching restoring the shell process state are very welcome |


Working on this again
Iteration circle into multiple PR.
Closes Issues #785, #567
Provide
app quit and process quit -> state restoration after shutdown / restart
This PR includes important changes in order to allow sessions record and restoration.
Concern
At the moment, the session is not affiliated to any opened tabs or splits in the
winobject. Sessions are created and then added to the sessions map in thewinobject so each win inside thewindowsSethas multiples session.Update
BrowserWindowSetofTabTabnow include a root Pane and each pane havechildsApply hyper
Record
Restoration
This way, we can record the

windowSetobject and apply the restoration on restart and reload the precedent recorded state.