Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix heredoc expansion #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohd-akram
force-pushed
the
fix-heredoc-expansion
branch
from
6490f8b
to
a6cb16b
Compare
mohd-akram
force-pushed
the
fix-heredoc-expansion
branch
from
a6cb16b
to
4f8d7bb
Compare
|
@darangi Could this be merged? |
|
You might find my bug report interesting: #165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description of the Change
Add support for recognizing expansions in heredocs. The
beginregexes of the existing rules are modified to not match the expanded form (which doesn't have quotes, see here). New rules for the expanded form are added that are identical to the existing ones minus the quotes. Thepatternsare taken from'string'(minus the quotes).Alternate Designs
None
Benefits
Variables in shell script heredocs will be correctly highlighted.
Possible Drawbacks
None
Applicable Issues
#151