Re-sync electron-link and electron-mksnapshot with atom/atom #2365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 235 235
Lines 13066 13066
Branches 1859 1859
=======================================
Hits 12209 12209
Misses 857 857Continue to review full report at Codecov.
|
|
Turns out any Relay version newer than 5.0.0 segfaults mksnapshot. I have no idea why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Looks like the versions of electron-link and electron-mksnapshot that we use to verify snapshottability in our CI builds have drifted from the ones in Atom:
https://github.com/atom/atom/blob/f0e4ca6d5d55f2422c107fcea93edba10ce816ac/script/package.json#L14-L15
Let's re-sync and fix any issues that have arisen in the meantime.