Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: minor: fix bug in test_developer_tool #856
Conversation
which failed to fail the test if an expected exception was raised. Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
lukpueh
force-pushed the
fix_another_try_except_else_test
branch
from
4a73a84
to
82fe71a
|
The PR does indeed correct a hole in the developer tool unit test, with the consequence that the test now fails. We need to find out if the full test is still valid and if so fix the developer tool. |
|
Documentation:
This is true: former is created with os.makedirs(), latter with os.mkdir() so the test as it's written should not expect failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The PR corrects a hole in one test's logic in
test_developer_tool. It's another instance of a test not failing if an expected error is not raised, due to flawed try/except/else construction.