Style fix ups #19
Merged
Style fix ups #19
Conversation
.editorconfig
Outdated
| @@ -1,3 +1,4 @@ | |||
| # Suppress: EC103 | |||
halter73
Mar 16, 2020
Member
Can we add a comment explaining what EC103 is? Looks like we have some file globbing patterns that don't match any files yet, but it took me a sec to find the doc.
Can we add a comment explaining what EC103 is? Looks like we have some file globbing patterns that don't match any files yet, but it took me a sec to find the doc.
anurse
Mar 16, 2020
Author
Contributor
Yeah... I might just either fix that up or remove the suppression entirely. It only shows up if you're using the EditorConfig Extension for VS.
Yeah... I might just either fix that up or remove the suppression entirely. It only shows up if you're using the EditorConfig Extension for VS.
.editorconfig
Outdated
| @@ -1,3 +1,4 @@ | |||
| # Suppress: EC103 | |||
| ; EditorConfig to support per-solution formatting. | |||
halter73
Mar 16, 2020
Member
I tried checking this branch out locally and looking at the .editorconfig file and VS gave me warnings about inconsistent line endings. Can we copy in the .gitattributes file from the aspnetcore repo to avoid this?
I tried checking this branch out locally and looking at the .editorconfig file and VS gave me warnings about inconsistent line endings. Can we copy in the .gitattributes file from the aspnetcore repo to avoid this?
anurse
Mar 16, 2020
Author
Contributor
Sure, good plan.
Sure, good plan.
| } | ||
|
|
||
| public void ReportError(string code, string itemId, string message) | ||
| { | ||
| this.logger.LogWarning($"Config error: '{code}', '{itemId}', '{message}'."); | ||
| _logger.LogWarning($"Config error: '{code}', '{itemId}', '{message}'."); |
BrennanConroy
Mar 17, 2020
Member
We need to fix these 😆
We need to fix these
anurse
Mar 17, 2020
Author
Contributor
Good catch, I can make a pass over them.
Good catch, I can make a pass over them.
anurse
Mar 17, 2020
Author
Contributor
Actually we should probably assign EventIds and such. I'll file a bug.
Actually we should probably assign EventIds and such. I'll file a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A whole bunch of style fix ups. I tried to make each commit a separate fix-up so it can be reviewed a little better.
I'm not expecting an in-depth review, just making sure something didn't get completely haywire.
Fixes #6